Repository navigation
lookup: update multer for remove skip and flaky properties - #1096
bjohansebas wants to merge 1 commit into
Conversation
bjohansebas
changed the title
|
friendly ping |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Module multer fails in Ubuntu / Node.js 26.x when manually tested in https://github.com/nodejs/citgm/actions/workflows/test-module.yml 
so although removing the skip for error: | 166 passing (10s)
error: | 1 failing
error: |
error: | 1) disk storage flush cleanup on aborted uploads
error: | should defer the abort unlink until the flush descriptor is closed:
error: |
error: | Uncaught AssertionError [ERR_ASSERTION]: _removeFile callback never fired (cleanup hung)
error: | + expected - actual
error: |
error: | -false
error: | +true
error: |
error: | at Timeout._onTimeout (test/abort-flush-fd-race.js:108:16)
error: | at listOnTimeout (node:internal/timers:685:17)
error: | at process.processTimers (node:internal/timers:618:7)
error: done | The smoke test has failed.cc: @LinusU @UlisesGascon |
|
I've separated the Ubuntu / Node.js 26 issue into #1165 |
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
Seems like this can land as we work independently on #1165 🤔
I can no longer reproduce this issue in GitHub Actions testing against Node.js 26.12.0 macOS / Ubuntu / Windows are all running without error, so I suggest to go ahead and merge this PR (including also the maintainer name changes). |
4 participants
The skip for win32 was added over 7 years ago (#487) — is it still failing?
Also, Multer isn’t failing on macOS anymore. all the tests are passing on macOS (bjohansebas/multer#1).
Closes #999
Closes expressjs/multer#1295
Checklist
npm testpasseshere